[Github] Add Timeouts to Premerge Jobs #164038
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The premerge jobs currently use the default timeouts. If something ends up hanging, they run for the full six hours. Given our jobs never actually take six hours other than when something hangs, we should set the timeouts lower to not use up machine capacity when something does go wrong. These limits were currently chosen conservatively, being a decent amount above the maximum run times I have seen over the past couple months, excluding six hour timeouts.
Member
|
@llvm/pr-subscribers-github-workflow Author: Aiden Grossman (boomanaiden154) ChangesThe premerge jobs currently use the default timeouts. If something ends up hanging, they run for the full six hours. Given our jobs never actually take six hours other than when something hangs, we should set the timeouts lower to not use up machine capacity when something does go wrong. These limits were currently chosen conservatively, being a decent amount above the maximum run times I have seen over the past couple months, excluding six hour timeouts. Full diff: https://github.com/llvm/llvm-project/pull/164038.diff 1 Files Affected:
diff --git a/.github/workflows/premerge.yaml b/.github/workflows/premerge.yaml
index 03c0c01d382ff..951fc16bed215 100644
--- a/.github/workflows/premerge.yaml
+++ b/.github/workflows/premerge.yaml
@@ -62,6 +62,7 @@ jobs:
with:
fetch-depth: 2
- name: Build and Test
+ timeout-minutes: 120
continue-on-error: ${{ runner.arch == 'ARM64' }}
run: |
git config --global --add safe.directory '*'
@@ -149,6 +150,7 @@ jobs:
echo "windows-runtimes=${runtimes_to_build}" >> $GITHUB_OUTPUT
echo "windows-runtimes-check-targets=${runtimes_check_targets}" >> $GITHUB_OUTPUT
- name: Build and Test
+ timeout-minutes: 180
if: ${{ steps.vars.outputs.windows-projects != '' }}
shell: cmd
run: |
|
cmtice
approved these changes
Oct 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The premerge jobs currently use the default timeouts. If something ends up hanging, they run for the full six hours. Given our jobs never actually take six hours other than when something hangs, we should set the timeouts lower to not use up machine capacity when something does go wrong. These limits were currently chosen conservatively, being a decent amount above the maximum run times I have seen over the past couple months, excluding six hour timeouts.